tabris/music-collection
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing delete
Some checks failed
Music Collection CI Workflow / test (./backend) (push) Successful in 22s
Details
Music Collection CI Workflow / test (./frontend) (push) Successful in 29s
Details
Music Collection CI Workflow / build-and-push-images (./backend/Dockerfile, git.anatid.net/tabris/msuic-collection-backend, ./backend) (push) Failing after 35s
Details
Music Collection CI Workflow / build-and-push-images (./frontend/Dockerfile, git.anatid.net/tabris/music-collection-frontend, ./frontend) (push) Successful in 1m44s
Details
Music Collection CI Workflow / deploy (push) Has been skipped
Details

Browse Source
This commit is contained in:
Phill Pover 2025-04-06 22:42:54 +01:00
parent 153460b8e9
commit 0d3fc109ac
4 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
backend/src/album/album.controller.ts
View File

@ -26,7 +26,7 @@ export class AlbumController {
@Put() @Put()
async update(@Param('id') id: number, @Body() updateAlbumDto: UpdateAlbumDto): Promise<string> { async update(@Param('id') id: number, @Body() updateAlbumDto: UpdateAlbumDto): Promise<string> {
return this.albumService.update(updateAlbumDto); return this.albumService.update(id, updateAlbumDto);
} }
@Delete(':id') @Delete(':id')

2
backend/src/album/album.entity.ts
View File

@ -15,6 +15,6 @@ export class Album {
@Column() @Column()
genre: string genre: string
@OneToMany(() => Song, (song) => song.album, { eager: true }) @OneToMany(() => Song, (song) => song.album, { eager: true, onDelete: 'CASCADE' })
songs: Song[] songs: Song[]
} }

4
backend/src/song/song.controller.ts
View File

@ -25,8 +25,8 @@ export class SongController {
} }
@Put() @Put()
async update(@Body() updateSongDto: UpdateSongDto): Promise<string> { async update(@Param('id') id: number, @Body() updateSongDto: UpdateSongDto): Promise<string> {
return this.songService.update(updateSongDto); return this.songService.update(id, updateSongDto);
} }
@Delete(':id') @Delete(':id')

20
backend/src/song/song.service.ts
View File

@ -30,15 +30,19 @@ export class SongService {
} }
async update(updateSongDto: UpdateSongDto): Promise<string> { async update(updateSongDto: UpdateSongDto): Promise<string> {
const song = this.songRepository.findOneBy({ id: updateSongDto.id }); if (id === updateSongDto.id) {
if (!song) const song = this.songRepository.findOneBy({ id: updateSongDto.id });
return "Song not found"; if (!song)
return "Song not found";
await this.songRepository.update({ id: updateSongDto.id }, { await this.songRepository.update({ id: updateSongDto.id }, {
title: updateSongDto.title, title: updateSongDto.title,
duration: updateSongDto.duration duration: updateSongDto.duration
}); });
return "Song updated successfully"; return "Song updated successfully";
} else {
return "Song ID does not match posted data"
}
} }
async remove(id: number): Promise<void> { async remove(id: number): Promise<void> {